Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add qr scanner #62

Merged
merged 26 commits into from
Feb 14, 2024
Merged

feat: add qr scanner #62

merged 26 commits into from
Feb 14, 2024

Conversation

ethan-tbd
Copy link
Contributor

@ethan-tbd ethan-tbd commented Feb 12, 2024 •
edited
Loading

closes #55

also generates a DID QR code in AccountDidPage

didpay_qr_demo.mov

simulator_screenshot_1E6940B2-08F0-42C9-86A8-50F1D4D2ACF2

@ethan-tbd ethan-tbd marked this pull request as ready for review February 14, 2024 01:38
@michaelneale
Copy link
Contributor

nice!

kirahsapong
kirahsapong approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@kirahsapong kirahsapong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiice!

test/features/send/send_page_test.dart Show resolved Hide resolved
wesbillman
wesbillman approved these changes Feb 14, 2024
View reviewed changes
ios/Runner/Info.plist Show resolved Hide resolved
lib/features/pfis/pfi_verification_page.dart Show resolved Hide resolved
lib/features/send/scan_qr_page.dart Outdated Show resolved Hide resolved
lib/features/send/scan_qr_page.dart Outdated Show resolved Hide resolved
lib/features/send/send_did_page.dart Outdated Show resolved Hide resolved
lib/features/send/send_did_page.dart Outdated Show resolved Hide resolved
lib/features/send/send_did_page.dart Outdated Show resolved Hide resolved
@ethan-tbd ethan-tbd merged commit d26c867 into main Feb 14, 2024
1 check passed
@ethan-tbd ethan-tbd deleted the add-qr-scanner branch February 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesbillman wesbillman wesbillman approved these changes

@kirahsapong kirahsapong kirahsapong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ScanQrPage
4 participants
@ethan-tbd @michaelneale @wesbillman @kirahsapong